plugins/hooks: run hooks when exit code != 0 - #5024
Merged
Merged
Conversation
Particularly for cases such as `docker exec -it`, it's relevant that the CLI still executes hooks even if the exec exited with a non-zero exit code, since this is can be part of a normal `docker exec` invocation depending on how the user exits. In the future, this might also be interesting to allow plugins to run hooks after an error so they can offer error-state recovery suggestions, although this would require additional work to give the plugin more information about the failed execution. Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5024 +/- ##
=======================================
Coverage 61.03% 61.04%
=======================================
Files 295 295
Lines 20648 20646 -2
=======================================
Hits 12603 12603
+ Misses 7148 7146 -2
Partials 897 897 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
This PR changes the hooks flow so that hooks are still invoked after the command execution returned an error/non-zero exit code.
I ran into this with
docker exec -it [] sh, since I was exiting with CTRL+D after doing things inside a container and depending on the exit code my hooks wouldn't get invoked, which isn't desired.In the future, this might also be interesting to allow plugins to run hooks after an error so they can offer error-state recovery suggestions, although this would require additional work to give the plugin more information about the failed execution.
- How to verify it
Try hooks after a non-zero exit code
docker exec- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)